[Fixed] UI: Keyboard options

Discussion related to "Everything" 1.5 Alpha.
Post Reply
NotNull
Posts: 5416
Joined: Wed May 24, 2017 9:22 pm

[Fixed] UI: Keyboard options

Post by NotNull »

Version = 1259

See screenshot. This should say Toggle window Hotkey: CTRL +SHIFT + OEM 102

It is working as intended and the value in the ini is correct too (0x0100 + 0x0400 + 0xE2 = 1506)

If not reproducible: this might have something to do with me experimenting with font sizes, although I think all is back to normal now.

2021-05-20 12_44_46-Everything Options.png
2021-05-20 12_44_46-Everything Options.png (6.05 KiB) Viewed 15090 times
void
Developer
Posts: 16494
Joined: Fri Oct 16, 2009 11:31 pm

Re: UI: Keyboard options

Post by void »

It's a bug with the standard Windows edit control and the ES_AUTOHSCROLL style.
The text offset is not recalculated after changing the edit size, causing the text to be cut off at the start.

Resizing the Everything options to the smallest possible width, setting the hotkey and then resizing the options window again will produce the issue.

Setting the hotkey again will fix the display problem.


In the past I've tried to bring the text back into view by moving the caret to the start and back to the original position, but this broke IME input.

Not using ES_AUTOHSCROLL will cut off the text to the right for thin edit controls (this might be undesirable).
NotNull
Posts: 5416
Joined: Wed May 24, 2017 9:22 pm

Re: UI: Keyboard options

Post by NotNull »

Thanks for the background details and explanation! I do like that (because I feel a little smarter now :))

Not a big problem or any problem at all, just mentioning in case it might help.


FWIW: I already tried re-entering the keyboard shortcut, but after re-opening the Options dialog, got the partial display again.
I will check (later) what my current font settings and related layout settings are.
void
Developer
Posts: 16494
Joined: Fri Oct 16, 2009 11:31 pm

Re: UI: Keyboard options

Post by void »

There's some sort of initialization issue here, the edit text is being set before the control is positioned.

I am working on a fix.
NotNull
Posts: 5416
Joined: Wed May 24, 2017 9:22 pm

Re: UI: Keyboard options

Post by NotNull »

I should be used to this after all this time (4 years! :o ), but I'm still amazed by the speed and how accurate you dig up the root cause of an issue ('the root of all evil').

Impressive ... Respect!
void
Developer
Posts: 16494
Joined: Fri Oct 16, 2009 11:31 pm

Re: UI: Keyboard options

Post by void »

This was caused by Everything moving the caret while the text box had a width of 0.
Only shortcut key edits were affected.

It should be fixed in Everything 1.5.0.1260.
NotNull
Posts: 5416
Joined: Wed May 24, 2017 9:22 pm

Re: UI: Keyboard options

Post by NotNull »

version 1260 (x64)
void wrote: Fri May 21, 2021 5:39 amIt should be fixed
It is. Thanks!

However ..
In 1260, when pressing the CTRL+SHIFT+\ hotkey a couple of times, the window does no longer appear.
That is to say: it is placed outside of view. It looks like the bottom right corner is in position 0,0 on the screen. The Everything window is also resized to 160*102 px. With the usual Windows tricks I can move the window back into the view area.

Reverting back to version 1259 immediately solves this issue.
void
Developer
Posts: 16494
Joined: Fri Oct 16, 2009 11:31 pm

Re: UI: Keyboard options

Post by void »

Thanks for checking v1260.

Everything 1.5.0.1261a should fix the issue with Everything showing in the wrong position.

Everything was accidentally setting the window position when -x -y -width or -height wasn't used.

If Everything appears off-screen, please press Alt + 2 to bring the Everything window back into view.
NotNull
Posts: 5416
Joined: Wed May 24, 2017 9:22 pm

Re: UI: Keyboard options

Post by NotNull »

Fixed. :thumbsup:
Post Reply